Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apache2 dependencies #6

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Remove apache2 dependencies #6

merged 2 commits into from
Apr 22, 2020

Conversation

maxme
Copy link

@maxme maxme commented Feb 6, 2020

Remove 2 dependencies that are under Apache v2 license:

  • removed keymirror.
  • removed shaka-player (used in iOS webviews).

I also ran gutenberg license checker to make sure everything went well:

node ~work/gutenberg/packages/scripts/scripts/check-licenses.js --prod --gpl2

@maxme maxme requested a review from Tug February 6, 2020 10:56
@maxme maxme mentioned this pull request Feb 6, 2020
Closed
@ceyhun ceyhun changed the base branch from master to fork-for-gutenberg-mobile April 6, 2020 13:54
@ceyhun ceyhun force-pushed the issue/remove-apache2-dependencies branch from 5bcad7f to 5c6697a Compare April 7, 2020 10:11
@ceyhun ceyhun mentioned this pull request Apr 7, 2020
Merged
2 tasks
@ceyhun ceyhun requested a review from cameronvoell April 15, 2020 11:09
@ceyhun ceyhun merged commit 6cdaddd into fork-for-gutenberg-mobile Apr 22, 2020
@ceyhun ceyhun deleted the issue/remove-apache2-dependencies branch April 22, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Awaiting requested review from Tug

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxme @ceyhun