Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change list type crash #880

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Fix change list type crash #880

merged 3 commits into from
Apr 17, 2019

Conversation

etoledom
Copy link
Contributor

This PR updates the Gutenberg ref to test the Fix change list type crash PR.

Screen Shot 2019-04-17 at 10 22 34 AM

To test:

  • Run the app.
  • Add a ListBlock.
  • Change the list type to Ordered List.
  • Check that it doesn't crash.

@etoledom etoledom added this to the v1.3 milestone Apr 17, 2019
@etoledom etoledom requested a review from hypest April 17, 2019 08:33
@etoledom etoledom self-assigned this Apr 17, 2019
@etoledom etoledom mentioned this pull request Apr 17, 2019
Merged
hypest
hypest approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on the finding Eduardo, this looks good to me!

@etoledom etoledom merged commit 032cef5 into develop Apr 17, 2019
@etoledom
Copy link
Contributor Author

Thank you! 🙏

@etoledom etoledom deleted the issue/fix-changeListType-not-function branch April 17, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@etoledom etoledom

Labels
[Type] Crash
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @hypest