FIX empty block creation on device running AOSP keyboard #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this on Android emulator, and it works. It also fixes this: #783 . 🎉 |
mkevins
approved these changes
Apr 11, 2019
...native-aztec/android/src/main/java/org/wordpress/mobile/ReactNativeAztec/ReactAztecText.java
Show resolved
Hide resolved
daniloercoli
deleted the
issue/856-empty-block-creation-fails-on-AOSP-keyboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #856 by making sure to check if text listeners are enabled before doing any text/block manipulating action
onEnteroronBackSpace.In this particular case the BackSpace.Key detection code in Aztec is called when the initial empty HTML content is set to the block via
setTextFromJS. Text listeners are disabled in this case, and those are not running, but InputFilters are not disabled.... By the way, I guess a better fix would involve changes to Aztec, but probably is easier to fix them here, since this change could also fix other potential problems in the future.Steps to repro: