Fixes pasting in heading blocks. #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
SergioEstevao
approved these changes
Mar 4, 2019
|
Sorry @diegoreymendez if the review process took so long. |
|
@daniloercoli - No worries! This is ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes pasting in header blocks, when the paste operation would result in a block split.
Details:
In order to achieve this I copied the splitting code from the paragraph block into the heading block.
There's a chance to unify code there, but I have purposely not stepped into that, as we would need to make sure all blocks that use rich text can use the same code (title?), or find a solution that would let us customize it for some blocks (this is probably what we'd want to do).
Related PRs:
Gutenberg PR: WordPress/gutenberg#14118
Testing: