Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase node max available memory in Build JS Bundles job #6579

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 25, 2024

Increases the max available memory that node can use. This follows the same approach applied in #6503 to avoid CI failures when building Gutenberg, which requires more memory than the default value (2GB).

To test:

  • Observe that all CI checks pass.
  • Observe in a1bc23e that the heap size is set to 4G (reference).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Tooling labels Jan 25, 2024
@fluiddot fluiddot marked this pull request as ready for review January 26, 2024 09:17
@@ -1,14 +1,4 @@
x-common-params:
- &gb-mobile-docker-container
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this common parameter as it's no longer used in the pipeline configuration.

@geriux geriux self-requested a review January 26, 2024 09:21
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this 🚀

@fluiddot fluiddot enabled auto-merge January 26, 2024 09:42
@fluiddot fluiddot merged commit 5f84e51 into trunk Jan 26, 2024
18 of 20 checks passed
@fluiddot fluiddot deleted the ci-fix-heap-out-of-memory-error branch January 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants