Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Add block outline to all Social Link blocks when selected #6120

Closed
wants to merge 1 commit into from
Closed

[RNMobile] Add block outline to all Social Link blocks when selected #6120

wants to merge 1 commit into from

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented Aug 29, 2023 •
edited by derekblank
Loading

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

Testing Instructions

  1. Create a Post and add a Social Links block.
  2. Tap one of the four initial blocks (WordPress, Facebook, Twitter, Instagram) and note the blue Block Outline appears when the block is selected.
  3. Tap the [+] button to the right of the initial blocks to open the Social Link block inserter.
  4. Add any block from the inserter: Amazon, Dribbble, Dropbox, etc.
  5. When the new block is added, the blue Block Outline should appear around the new block. When de-selected by tapping anywhere else in the editor, and reselecting the block by tapping it, the blue Block Outline should appear.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

2 similar comments
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

dcalhoun
dcalhoun approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#54011 (review).

@derekblank derekblank mentioned this pull request Aug 30, 2023
Merged
@wpmobilebot
Copy link
Collaborator Author

This PR is closed because there is no longer an associated gutenberg PR for it.

If you'd like to keep a PR open after its upstream counterpart is closed, please assign it to a team member or create a new commit.

@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/rnmobile/outline-all-social-link-blocks branch August 30, 2023 00:23
@derekblank derekblank restored the version-toolkit/gutenberg/rnmobile/outline-all-social-link-blocks branch August 30, 2023 00:29
@derekblank derekblank reopened this Aug 30, 2023
@wpmobilebot
Copy link
Collaborator Author

This PR is closed because there is no longer an associated gutenberg PR for it.

If you'd like to keep a PR open after its upstream counterpart is closed, please assign it to a team member or create a new commit.

@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/rnmobile/outline-all-social-link-blocks branch August 30, 2023 00:34
@derekblank derekblank mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpmobilebot @dcalhoun @derekblank