Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable details settings for not belonged VideoPress videos #5782

Merged

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 16, 2023

Related PRs:

To test:
Follow testing instructions from Automattic/jetpack#30759.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 1.96.0 (22.5) milestone May 16, 2023
@fluiddot fluiddot self-assigned this May 16, 2023
GET: [
...endpoints.GET,
/rest\/v1.1\/videos.*/i,
/wpcom\/v2\/videopress\/\w*\/check-ownership\/.*/i,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint is used to check if a video belongs to a site.

@fluiddot fluiddot marked this pull request as ready for review May 16, 2023 18:34
@fluiddot fluiddot requested review from jhnstn and SiobhyB May 16, 2023 18:34
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 17, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun
Copy link
Member

Apologies for introducing a failing sync-android CI task on this PR. It should not block merging this PR. I triggered it as a test: pdnsEh-18K-p2#comment-2281.

Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot fluiddot enabled auto-merge May 22, 2023 14:55
@fluiddot fluiddot merged commit 7a26ade into trunk May 22, 2023
@fluiddot fluiddot deleted the videopress-disable-details-settings-not-belonged-videos branch May 22, 2023 15:42
@derekblank derekblank mentioned this pull request May 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants