Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VideoPress block on Android #5780

Merged
merged 8 commits into from
May 19, 2023
Merged

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 16, 2023

Related PRs:

This PR enables the VideoPress block on Android.

To test:

  1. Open the Android app and connect it with the local Metro server.
  2. Open/create a post.
  3. Tap ➕ button to open the block inserter.
  4. Observe that the VideoPress block is displayed.
  5. Tap on the VideoPress block to add it.
  6. Add a video.
  7. Observe that the video is displayed and can be played.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this May 16, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 16, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot requested review from jhnstn and SiobhyB May 16, 2023 14:30
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot, looking good! Happy to approve after the unused import is removed. I think the supported-blocks.json file can also be updated to reflect that the block's available on both platforms.

@fluiddot
Copy link
Contributor Author

I think the supported-blocks.json file can also be updated to reflect that the block's available on both platforms.

Good idea. I've updated in f190407.

Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @fluiddot 🙌

fluiddot added 2 commits May 16, 2023 18:37
# Conflicts:
#	src/block-support/supported-blocks.json
@fluiddot fluiddot added this to the 1.96.0 (22.5) milestone May 16, 2023
@fluiddot fluiddot enabled auto-merge May 19, 2023 16:50
@fluiddot fluiddot merged commit 59d2d6b into trunk May 19, 2023
@fluiddot fluiddot deleted the enable-videopress-block-android branch May 19, 2023 17:27
@derekblank derekblank mentioned this pull request May 25, 2023
4 tasks
@fluiddot fluiddot mentioned this pull request May 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants