Release 1.71.0

.circleci/config.yml

@@ -179,7 +179,7 @@ jobs:
           name: Run Checks
           command: bin/ci-checks-js.sh
           environment:
-            JEST_JUNIT_OUTPUT: "reports/test-results/android-test-results.xml"
+            JEST_JUNIT_OUTPUT_FILE: "reports/test-results/android-test-results.xml"
       - store_test_results:
           path: ./reports/test-results
   android-device-checks:
@@ -223,7 +223,7 @@ jobs:
           environment:
             TEST_RN_PLATFORM: android
             TEST_ENV: sauce
-            JEST_JUNIT_OUTPUT: "/home/circleci/test-results/android-test-results.xml"
+            JEST_JUNIT_OUTPUT_FILE: "/home/circleci/test-results/android-test-results.xml"
       - store_test_results:
           path: /home/circleci/test-results
       - when:
@@ -319,7 +319,7 @@ jobs:
           npm run device-tests<<parameters.is-canary>>
         no_output_timeout: 1200
         environment:
-          JEST_JUNIT_OUTPUT: "reports/test-results/ios-test-results.xml"
+          JEST_JUNIT_OUTPUT_FILE: "reports/test-results/ios-test-results.xml"
     - store_test_results:
         path: ./reports/test-results
     - run:

README.md

@@ -219,13 +219,13 @@ const pluginTranslations = [
 ];
 ```
 
-## Caveats
+### Caveats
 - Strings that are only used in the native version, and reference a [context](https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#disambiguation-by-context), won't be included in the localization strings files hence, they won't be translated. This is a limitation in the format of the localization strings files.
 - Localization strings files don’t support domains, so the strings extracted from plugins that are only used in the native version, will be unified in the same file, which might involve string conflicts.
 
-## Troubleshooting
+### Troubleshooting
 
-### A string is missing the translation
+#### A string is missing the translation
 This can be produced by several causes, check the following steps in order to identify the source:
 - Verify that the string uses the `__` i18n function or similar ([reference](https://github.com/WordPress/gutenberg/blob/trunk/packages/i18n/README.md)).
 - Check for warnings in the output when running `i18n:update` NPM command, especially the following ones:

RELEASE-NOTES.txt

@@ -1,6 +1,10 @@
 Unreleased
 ---
 
+1.71.0
+---
+* [*] Image block: Replacing the media for an image set as featured prompts to update the featured image [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3930]
+* [***] Font size and line-height support for text-based blocks used in block-based themes [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4519]
 
 1.70.1
 ---

bin/strings2android.js

@@ -43,21 +43,52 @@ function escapeResourceXML( unsafeXMLValue ) {
 	} );
 }
 
+/**
+ * Replacement for complying the TypographyDashes Android lint rule.
+ * Reference: https://android.googlesource.com/platform/tools/base/+/master/lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/TypographyDetector.java#58
+ *
+ * @param {string} XMLValue input to apply replacement.
+ * @return {string} valid string passing TypographyDashes Android lint rule.
+ */
+function replaceHyphenInNumberRanges( XMLValue ) {
+	return XMLValue.replace( /(\d+\s*)(-)(\s*\d+)/gm, function(
+		match,
+		p1,
+		p2,
+		p3
+	) {
+		// Make sure that if there is no space before digit there isn't
+		// one on the left either -- since we don't want to consider
+		// "1 2 -3" as a range from 2 to 3
+		const isNegativeNumber = p3[ 0 ] !== ' ' && p1[ p1.length - 1 ] === ' ';
+
+		return [ p1, p3 ].join( isNegativeNumber ? p2 : '–' );
+	} );
+}
+
+/**
+ * Replacement for complying the TypographyEllipsis Android lint rule.
+ * Reference: https://android.googlesource.com/platform/tools/base/+/master/lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/TypographyDetector.java#106
+ *
+ * @param {string} XMLValue input to apply replacements.
+ * @return {string} valid string passing TypographyEllipsis Android lint rule.
+ */
+const THREE_DOTS_PATTERN = /(\.\.\.)/gm;
+function replaceEllipsis( XMLValue ) {
+	return XMLValue.replace( THREE_DOTS_PATTERN, '…' );
+}
+
 /**
  * Android specifics replacements.
  *
  * @param {string} XMLValue input to apply replacements.
- * @return {string} valid string passing Android linter rules.
+ * @return {string} valid string passing Android lint rules.
  */
 function androidReplacements( XMLValue ) {
-	return XMLValue.replace( /(-|\.\.\.)/gm, function( character ) {
-		switch ( character ) {
-			case '-':
-				return '–'; // Android lint rule: TypographyDashes.
-			case '...':
-				return '…'; // Android lint rule: TypographyEllipsis
-		}
-	} );
+	return [ replaceHyphenInNumberRanges, replaceEllipsis ].reduce(
+		( value, replacement ) => replacement( value ),
+		XMLValue
+	);
 }
 
 /**

bundle/android/strings.xml

@@ -6,7 +6,7 @@
     <string name="gutenberg_native_1_s_2_s_is_3_s_4_s" tools:ignore="UnusedResources">%1$s. %2$s is %3$s %4$s.</string>
     <!-- translators: 1: From block title, e.g. Paragraph. 2: To block title, e.g. Header. -->
     <string name="gutenberg_native_1_s_transformed_to_2_s" tools:ignore="UnusedResources">%1$s transformed to %2$s</string>
-    <string name="gutenberg_native_add_a_new_block_at_any_time_by_tapping_on_the_icon_in_the_toolbar" tools:ignore="UnusedResources">Add a new block at any time by tapping on the + icon in the toolbar on the bottom left. </string>
+    <string name="gutenberg_native_add_a_new_block_at_any_time_by_tapping_on_the_icon_in_the_toolbar" tools:ignore="UnusedResources">Add a new block at any time by tapping on the + icon in the toolbar on the bottom left.</string>
     <string name="gutenberg_native_add_a_shortcode" tools:ignore="UnusedResources">Add a shortcode…</string>
     <string name="gutenberg_native_add_alt_text" tools:ignore="UnusedResources">Add alt text</string>
     <string name="gutenberg_native_add_audio" tools:ignore="UnusedResources">ADD AUDIO</string>
@@ -99,12 +99,12 @@
     <string name="gutenberg_native_customize_blocks" tools:ignore="UnusedResources">Customize blocks</string>
     <string name="gutenberg_native_customize_gradient" tools:ignore="UnusedResources">Customize Gradient</string>
     <string name="gutenberg_native_cut_block" tools:ignore="UnusedResources">Cut block</string>
-    <string name="gutenberg_native_describe_the_purpose_of_the_image_leave_empty_if_the_image_is_pur" tools:ignore="UnusedResources">Describe the purpose of the image. Leave empty if the image is purely decorative. </string>
+    <string name="gutenberg_native_describe_the_purpose_of_the_image_leave_empty_if_the_image_is_pur" tools:ignore="UnusedResources">Describe the purpose of the image. Leave empty if the image is purely decorative.</string>
     <string name="gutenberg_native_dismiss" tools:ignore="UnusedResources">Dismiss</string>
     <string name="gutenberg_native_double_tap_and_hold_to_edit" tools:ignore="UnusedResources">Double tap and hold to edit</string>
     <string name="gutenberg_native_double_tap_to_add_a_block" tools:ignore="UnusedResources">Double tap to add a block</string>
     <string name="gutenberg_native_double_tap_to_add_a_link" tools:ignore="UnusedResources">Double tap to add a link.</string>
-    <string name="gutenberg_native_double_tap_to_change_unit" tools:ignore="UnusedResources">double–tap to change unit</string>
+    <string name="gutenberg_native_double_tap_to_change_unit" tools:ignore="UnusedResources">double-tap to change unit</string>
     <string name="gutenberg_native_double_tap_to_edit_button_text" tools:ignore="UnusedResources">Double tap to edit button text</string>
     <string name="gutenberg_native_double_tap_to_edit_label_text" tools:ignore="UnusedResources">Double tap to edit label text</string>
     <string name="gutenberg_native_double_tap_to_edit_placeholder_text" tools:ignore="UnusedResources">Double tap to edit placeholder text</string>
@@ -291,7 +291,7 @@ translators: Block name. %s: The localized block name -->
     <!-- translators: %s: social link name e.g: "Instagram". -->
     <string name="gutenberg_native_s_has_url_set" tools:ignore="UnusedResources">%s has URL set</string>
     <!-- translators: Missing block alert title. %s: The localized block name -->
-    <string name="gutenberg_native_s_is_not_fully_supported" tools:ignore="UnusedResources">\'%s\' is not fully–supported</string>
+    <string name="gutenberg_native_s_is_not_fully_supported" tools:ignore="UnusedResources">\'%s\' is not fully-supported</string>
     <!-- translators: %s: embed block variant's label e.g: "Twitter". -->
     <string name="gutenberg_native_s_link" tools:ignore="UnusedResources">%s link</string>
     <!-- translators: %s: embed block variant's label e.g: "Twitter". -->
@@ -356,8 +356,8 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
     <string name="gutenberg_native_what_is_alt_text" tools:ignore="UnusedResources">What is alt text?</string>
     <string name="gutenberg_native_width_settings" tools:ignore="UnusedResources">Width Settings</string>
     <string name="gutenberg_native_wordpress_media_library" tools:ignore="UnusedResources">WordPress Media Library</string>
-    <string name="gutenberg_native_x_axis_position" tools:ignore="UnusedResources">X–Axis Position</string>
-    <string name="gutenberg_native_y_axis_position" tools:ignore="UnusedResources">Y–Axis Position</string>
+    <string name="gutenberg_native_x_axis_position" tools:ignore="UnusedResources">X-Axis Position</string>
+    <string name="gutenberg_native_y_axis_position" tools:ignore="UnusedResources">Y-Axis Position</string>
     <string name="gutenberg_native_you_can_edit_this_block_using_the_web_version_of_the_editor" tools:ignore="UnusedResources">You can edit this block using the web version of the editor.</string>
     <string name="gutenberg_native_you_can_rearrange_blocks_by_tapping_a_block_and_then_tapping_the" tools:ignore="UnusedResources">You can rearrange blocks by tapping a block and then tapping the up and down arrows that appear on the bottom left side of the block to move it above or below other blocks.</string>
 </resources>