Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.69.0 #4438

Merged
merged 209 commits into from
Jan 8, 2022
Merged

Release 1.69.0 #4438

merged 209 commits into from
Jan 8, 2022

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Jan 7, 2022

Release for Gutenberg Mobile 1.69.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Give multi-line block names central alignment in inserter

Fix missing translations by refactoring the editor initialization code

Add Jetpack and Layout Grid translations

Fix text formatting mode lost after backspace is used

Add missing translations of unsupported block editor modal

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

dcalhoun and others added 30 commits November 9, 2021 12:01
The changes in this patch are now included from the upstream update.
Result of `npm install` after updating the Gutenberg ref.
…ous commit it pointed to no longer exists in the tree.
…-native-0.66-wpios-integration

[RN 0.66 Upgrade] WPiOS integration
@mkevins mkevins requested a review from ttahmouch January 7, 2022 07:09
@mkevins mkevins marked this pull request as ready for review January 7, 2022 07:09
@@ -1,13 +1,22 @@
Unreleased
---

1.69.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. 👍

@@ -1,6 +1,6 @@
{
"name": "gutenberg-mobile",
"version": "1.68.0",
"version": "1.69.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good to me. 👍

@ttahmouch ttahmouch merged commit 738ebcc into trunk Jan 8, 2022
@ttahmouch ttahmouch deleted the release/1.69.0 branch January 8, 2022 19:26
@mkevins
Copy link
Contributor Author

mkevins commented Jan 11, 2022

Sanity tests - Android - Suite 3

Build: wpandroid-19.0-rc-1-Signed.apk
Device: Pixel 3a (physical device)

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • ❌ Gallery block - Settings: Link to - TC012

Attachment Page and Media File options seem to be not working for self-hosted sites. Note: inner Image blocks still have "None" selected, so perhaps the setting is not being applied to the inner Image blocks?

  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@ttahmouch
Copy link
Contributor

ttahmouch commented Jan 11, 2022

WPiOS 19.0.0.0 – Writing flow tests

Device: iPhone 13 Pro Max (15.1.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@mkevins
Copy link
Contributor Author

mkevins commented Jan 12, 2022

🟢 Writing Flow checklist - Android

Build: wpandroid-19.0-rc-1-Signed.apk
Device: Pixel 3a (physical device)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • 🟡 TC002 - Merge after selection - Known issue (described in test)
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@ttahmouch
Copy link
Contributor

ttahmouch commented Jan 12, 2022

WPiOS 19.0.0.0 – Unsupported Block Editor tests

Device: iPhone 13 Pro Max (15.1.1)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password (⚠️ caveat: if Jetpack is installed and connected on the site, editing unsupported blocks is allowed)

@mkevins
Copy link
Contributor Author

mkevins commented Jan 13, 2022

Testing changes - Android

Build: wpandroid-19.0-rc-1-Signed.apk
Device: Pixel 3a (physical device)

✔️ Give multi-line block names central alignment in inserter

✔️ Fix missing translations by refactoring the editor initialization code

✔️ Add Jetpack and Layout Grid translations

✔️ Fix text formatting mode lost after backspace is used

🟡 Add missing translations of unsupported block editor modal

@mkevins
Copy link
Contributor Author

mkevins commented Jan 13, 2022

Testing changes - iOS

Build: Testflight 9.0.0.1
Device: iPhone 11 (physical device)

✔️ Give multi-line block names central alignment in inserter

✔️ Fix missing translations by refactoring the editor initialization code

✔️ Add Jetpack and Layout Grid translations

✔️ Fix text formatting mode lost after backspace is used

✔️ Add missing translations of unsupported block editor modal

@mkevins
Copy link
Contributor Author

mkevins commented Jan 13, 2022

✔️ Unsupported Block Tests - Android

Build: wpandroid-19.0-rc-1-Signed.apk
Device: Pixel 3a (physical device)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor

fluiddot commented Jan 13, 2022

❓ Add Jetpack and Layout Grid translations

Thanks @mkevins for testing this change in the release 🙇 ! I've just checked that mentioned the string Link address to Google Maps is already included in the Jetpack's GlotPress project (reference) where all translations for Jetpack are held. So that string is not expected to be part of the localization string files (i.e. bundle/android/strings.xml file), as these files only contain those strings that are exclusively referenced in JS native files (i.e. *.native.js).

For verifying this change, it would be enough by checking if the string is actually translated when changing the device's language to non-English. Were you able to check this?

@ttahmouch
Copy link
Contributor

ttahmouch commented Jan 13, 2022

Sanity tests - iOS - Suite 3

Note

I incorrectly assumed the tests that would be conducted on the iOS release would be the same suite as the Android release when they should have been Suites 4 and 5. So I am moving on to those suites and do not intend to finish this suite.

Device: iPhone 13 Pro Max (15.1.1)

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
    ❌ The test itself passed, but steps following the test resulted in a crash defect that prompted a new PR. I was able to make the Retry button appear by preempting the image upload with Airplane Mode on a slow network connection, but when I pressed the Retry button while in Airplane Mode it caused the application to crash.
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
    Attachment Page option doesn't work for self-hosted sites if the post is published as Private. It works correctly again when switching the post to Public. If the Gallery > Image in a Private post has an Attachment Page link set, then the attachment page opens as a 404 page. I do not experience the same issue on a Private page published using wordpress.com in my desktop browser.

Skipped

  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

Sanity tests - iOS - Suite 4

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
    ❌ Contrary to the suggestion in the Deprecation Notice, it was not possible to create a Spacer in WP.com first with a value higher than 500px using the GUI (as it would force adjust it to 500px in the text input) or using the HTML editor (as it strips out <!-- wp:spacer {"height":"1600px"} --> back to <!-- wp:spacer --> when you attempt to save the post). If I modify it to <!-- wp:spacer {"height":"1600px"} --> and update the post in WP-iOS instead of WP.com, it saves correctly with the added JSON object in the HTML comment, but it renders with an error in the WP.com editor and only previews correctly in Tablet and Desktop mode; not Mobile mode. From parallel conversation, there may be recent changes that have been made to the block parser that have caused this regression regarding stripping the metadata from the HTML comments (but we haven't attempted to dive into it yet). It does render correctly in the WP-iOS editor if I modify to 1600px in the GUI text input; just not Mobile preview mode.
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006
    Note: I needed to press Reset to return to the original set color. It didn't default back to it when pressing outside the action sheet. I think the UX expectations may have changed to "auto-set" the color when selecting outside of the action sheet, but I'm not positive at the moment.
Next Steps:
+ Press Custom button
+ Play with picker and select different color
+ Press anywhere outside the sheet to close it

Expected behavior:
+ Background color returned to the set color

@mkevins
Copy link
Contributor Author

mkevins commented Jan 14, 2022

So that string is not expected to be part of the localization string files (i.e. bundle/android/strings.xml file), as these files only contain those strings that are exclusively referenced in JS native files (i.e. *.native.js).

Thanks for the explanation @fluiddot !

For verifying this change, it would be enough by checking if the string is actually translated when changing the device's language to non-English. Were you able to check this?

I checked this on Android and iOS, and that string is present (e.g. "Dirección del enlace a Google Maps"), so I think it's working correctly. 😌

@mkevins mkevins restored the release/1.69.0 branch January 17, 2022 06:16
@ttahmouch
Copy link
Contributor

ttahmouch commented Jan 19, 2022

Sanity tests - iOS - Suite 5

Video block - 1

  • Video block - Insert video from device (failing) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

❌ There appears to be issues if you are using a self-hosted site. I tested with this generated, self-hosted Jetpack site, https://footed-lemming.jurassic.ninja. The upload UX appeared to work and would show the file uploading and the Video block changing metadata in the block editor HTML mode. It even showed the block edits in the wp-admin page as well, but the video files weren't able to be found in the Media section of wp-admin; only image files from previous Image block tests were found. When I switched to an Atomic site everything worked as expected, i.e., when the file finished upload I saw an image thumbnail of the first frame of the video as opposed to an error that said "Media Options > File Type Unknown."

File block - 1

  • File block - Upload completes successfully from the device library - steps
  • File block - Insert completes successfully from the WordPress Media library - steps
  • File block - Upload fails from the device library - steps
  • File block - Stop the file upload before it completes - steps

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps
    ❌ The Attachment Page appears to be a 404 "Resource Not Found" page when linking to the attachment page on the File block in both an Atomic site and Jeptack self-hosted site. It works correctly when linking directly to the Media File, and opens it in my device browser.

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
    ❌ I'm currently unsure if it matters whether or not I have an Atomic site or a Jetpack site selected, and I think I experienced this issue on both, but I am consistently seeing an issue on the Atomic site that if I select the Block Settings I see the Hide Download Button toggle until I press Link Settings, and then I can no longer get it to return to the action sheet. It will only show the subset of actions from the Link Settings in the action sheet when I press the Block Settings button. When Hide Download Button is available it does work correctly.
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

  • Reusable block - Add block - steps
  • Reusable block - Convert to regular blocks - steps

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants