-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.69.0 #4438
Release 1.69.0 #4438
Conversation
The changes in this patch are now included from the upstream update.
Result of `npm install` after updating the Gutenberg ref.
…e into chore/upgrade-to-react-native-0.66
…e into chore/upgrade-to-react-native-0.66
…ous commit it pointed to no longer exists in the tree.
…-native-0.66-wpios-integration [RN 0.66 Upgrade] WPiOS integration
@@ -1,13 +1,22 @@ | |||
Unreleased | |||
--- | |||
|
|||
1.69.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. 👍
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "gutenberg-mobile", | |||
"version": "1.68.0", | |||
"version": "1.69.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good to me. 👍
…se branch of `gutenberg`.
Sanity tests - Android - Suite 3Build: wpandroid-19.0-rc-1-Signed.apk Gallery - 2
Gallery - 3
Gallery - 4
Attachment Page and Media File options seem to be not working for self-hosted sites. Note: inner Image blocks still have "None" selected, so perhaps the setting is not being applied to the inner Image blocks? Columns - 2
Columns - 3
Columns - 4
MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Social Icons - 2
Image - 2
Story block - 1 |
WPiOS 19.0.0.0 – Writing flow testsDevice: iPhone 13 Pro Max (15.1.1) General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
🟢 Writing Flow checklist - AndroidBuild: wpandroid-19.0-rc-1-Signed.apk General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
WPiOS 19.0.0.0 – Unsupported Block Editor testsDevice: iPhone 13 Pro Max (15.1.1)
|
Testing changes - AndroidBuild: wpandroid-19.0-rc-1-Signed.apk ✔️ Give multi-line block names central alignment in inserter
✔️ Fix missing translations by refactoring the editor initialization code
✔️ Add Jetpack and Layout Grid translations
✔️ Fix text formatting mode lost after backspace is used
🟡 Add missing translations of unsupported block editor modal
|
Testing changes - iOSBuild: Testflight 9.0.0.1 ✔️ Give multi-line block names central alignment in inserter
✔️ Fix missing translations by refactoring the editor initialization code
✔️ Add Jetpack and Layout Grid translations
✔️ Fix text formatting mode lost after backspace is used
✔️ Add missing translations of unsupported block editor modal |
✔️ Unsupported Block Tests - AndroidBuild: wpandroid-19.0-rc-1-Signed.apk
|
Thanks @mkevins for testing this change in the release 🙇 ! I've just checked that mentioned the string For verifying this change, it would be enough by checking if the string is actually translated when changing the device's language to non-English. Were you able to check this? |
Sanity tests - iOS - Suite 3NoteI incorrectly assumed the tests that would be conducted on the Device: iPhone 13 Pro Max (15.1.1) Gallery - 2
Gallery - 3
Gallery - 4
SkippedColumns - 2
Columns - 3
Columns - 4
MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Social Icons - 2
Image - 2
Story block - 1
Sanity tests - iOS - Suite 4DarkMode - 2
Group - 2
Spacer - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2
|
Thanks for the explanation @fluiddot !
I checked this on Android and iOS, and that string is present (e.g. "Dirección del enlace a Google Maps"), so I think it's working correctly. 😌 |
Sanity tests - iOS - Suite 5Video block - 1
Video block - 2
❌ There appears to be issues if you are using a self-hosted site. I tested with this generated, self-hosted Jetpack site, https://footed-lemming.jurassic.ninja. The upload UX appeared to work and would show the file uploading and the File block - 1
File block - 2
File block - 3
Audio block - 1
Audio block - 2
Audio block - 3
Audio block - 4
Reusable block - 1 Reusable block - 2 Embed block - 1
Embed block - 2
|
Release for Gutenberg Mobile 1.69.0
Related PRs
Gutenberg: Mobile Release v1.69.0 WordPress/gutenberg#37767
WPAndroid: Integrate gutenberg-mobile release 1.69.0 WordPress-Android#15805
WPiOS: Integrate gutenberg-mobile release 1.69.0 WordPress-iOS#17726
Aztec-iOS: N/A
Aztec-Android: N/A
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
Give multi-line block names central alignment in inserter
Fix missing translations by refactoring the editor initialization code
Add Jetpack and Layout Grid translations
Fix text formatting mode lost after backspace is used
Add missing translations of unsupported block editor modal
Test plan
Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.
Release Submission Checklist
RELEASE-NOTES.txt
is updated with all the changes that made it to the release. ReplaceUnreleased
section with the release version and create a newUnreleased
section.gutenberg/packages/react-native-editor/CHANGELOG.md
is updated with all the changes that made it to the release. Replace## Unreleased
with the release version and create a new## Unreleased
.