Update submodule dependencies #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes originate from updated dependencies within the `gutenberg` submodule.
dcalhoun
force-pushed
the
chore/update-submodule-dependencies
branch
from
b12bad1 to
1afcc85
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
The outdated packages resulted in the following CI failure. ``` TypeError: snapshotResolver.resolveSnapshotPath is not a function at Object._default [as default] (node_modules/jest-jasmine2/build/setup_jest_globals.js:101:41) ``` These updates were completed to resolve the error and mirror updates within the `gutenberg` submodule, which updated `jest-snapshot`: WordPress/gutenberg#37396 The cause of the error is a breaking change that landed in `jest-snapshots@27`: jestjs/jest#8829
dcalhoun
commented
Dec 16, 2021
fluiddot
previously approved these changes
Dec 17, 2021
This reverts commit 6625413.
The Jest test runner found was resolving different version of Jest sub-dependencies, which resulted in the following error. ``` TypeError: snapshotResolver.resolveSnapshotPath is not a function at Object._default [as default] (node_modules/jest-jasmine2/build/setup_jest_globals.js:101:41) ``` Specifically, the test runner resolved `node_modules/[email protected] > gutenberg/node_modules/[email protected]`. `jest-snapshot@27` includes a breaking change of a newly returned `Promise`: jestjs/jest#8829 This reordering prioritizes the dependencies found in the top-level `node_modules` directory over the directory found within the `gutenberg` submodule.
This reverts commit 1afcc85.
These changes originate from updated dependencies within the `gutenberg` submodule. These changes are the result of clearing out all `node_modules` directories, and running `npm install` three times.
dcalhoun
dismissed
fluiddot’s stale review
The proposed changes have changed drastically since review.
guarani
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
The changes look good!
In the package-lock.json file I see only changes to @types/react and @types/react-dom which come from the update to the Gutenberg submodule (I see the same version updates there).
Thanks so much @dcalhoun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Gutenberg version and capture lock file changes originating from dependency updates within the
gutenbergsubmodule.Additionally, the Jest test runner was resolving different version of Jest sub-dependencies, which resulted in the following error.
Specifically, the test runner resolved
node_modules/[email protected] > gutenberg/node_modules/[email protected].jest-snapshot@27includes a breaking change of a newly returnedPromise: jestjs/jest#8829This reordering prioritizes the dependencies found in the top-level
node_modulesdirectory over the directory found within thegutenbergsubmodule. The origin of this incorrect module resolution is a combination of WordPress/gutenberg#37396 and WordPress/gutenberg#33448.To test: Passing CI checks should suffice.
PR submission checklist: