Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Fix inline preview cut-off when editing URL #4072

Merged
merged 6 commits into from
Oct 6, 2021
Merged

[Embed block] Fix inline preview cut-off when editing URL #4072

merged 6 commits into from
Oct 6, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Oct 4, 2021 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#35321

Fixes #4059

To test:
Follow testing instructions from WordPress/gutenberg#35321.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Embed block labels Oct 4, 2021
@fluiddot fluiddot requested a review from jd-alexander October 4, 2021 12:38
@fluiddot fluiddot self-assigned this Oct 4, 2021
@fluiddot fluiddot mentioned this pull request Oct 4, 2021
Merged
7 tasks
@fluiddot fluiddot changed the title Fix inline preview cut-off when editing URL [Embed block] Fix inline preview cut-off when editing URL Oct 4, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 4, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jd-alexander
jd-alexander approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#35321 (review)

@fluiddot fluiddot added this to the 1.64.0 (18.5) milestone Oct 6, 2021
@fluiddot fluiddot enabled auto-merge October 6, 2021 08:10
@fluiddot fluiddot merged commit 47ae358 into develop Oct 6, 2021
@fluiddot fluiddot deleted the fix/embed-block-preview-cut-off branch October 6, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Milestone
1.64.0 (18.5)
Development

Successfully merging this pull request may close these issues.

Embed block: Inline preview cut-off when editing URL
2 participants
@fluiddot @jd-alexander