Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Detect when an embeddable URL is pasted into an empty paragraph #4048

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Sep 29, 2021

Fixes #3280 #3281

To test:
WordPress/gutenberg#35204
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Sorry, something went wrong.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 30, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander marked this pull request as ready for review September 30, 2021 06:07
@fluiddot
Copy link
Contributor

fluiddot commented Sep 30, 2021

@jd-alexander I think we should reference the #3281 issue in this PR as it's also being addressed with these changes, wdyt?

@twstokes
Copy link
Contributor

Hey @jd-alexander. We will cut the 1.63.0 release today. Please let me know if you’d like to bump this to the next milestone or rather us work to include this PR in 1.63.0. Thanks!

@jd-alexander
Copy link
Contributor Author

@jd-alexander I think we should reference the #3281 issue in this PR as it's also being addressed with these changes, wdyt?

Good suggestion @fluiddot Done!

@jd-alexander jd-alexander force-pushed the issue-3280/embed-block-paste-url branch from e118e13 to 9387cfa Compare October 5, 2021 01:29
@jd-alexander jd-alexander requested a review from fluiddot October 7, 2021 04:08
@geriux
Copy link
Contributor

geriux commented Oct 13, 2021

Hey @jd-alexander 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks!

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jd-alexander 💯 !

Approved via WordPress/gutenberg#35204 (review).

NOTE: Gutenberg ref should be updated once the related Gutenberg PR is merged.

@jd-alexander jd-alexander force-pushed the issue-3280/embed-block-paste-url branch from bac406f to 2cd1e51 Compare October 13, 2021 17:46
@jd-alexander
Copy link
Contributor Author

Awesome work @jd-alexander 💯 !

Approved via WordPress/gutenberg#35204 (review).

NOTE: Gutenberg ref should be updated once the related Gutenberg PR is merged.

Thanks @fluiddot I will do the relevant updates 🙇🏾

@jd-alexander jd-alexander merged commit c56146d into develop Oct 13, 2021
@jd-alexander jd-alexander deleted the issue-3280/embed-block-paste-url branch October 13, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants