Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tarball instead of git tag for forked dependencies #3982

Merged
merged 15 commits into from
Sep 28, 2021
Merged

Use tarball instead of git tag for forked dependencies #3982

merged 15 commits into from
Sep 28, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Sep 17, 2021 •
edited by fluiddot
Loading

Gutenberg PR: WordPress/gutenberg#34886
WPAndroid PR: wordpress-mobile/WordPress-Android#15362
WPiOS PR: wordpress-mobile/WordPress-iOS#17198

Fixes #

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 17, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

This was referenced Sep 20, 2021
Merged
Merged
@ceyhun ceyhun changed the title Use tarball instead of git tag for fork dependencies Use tarball instead of git tag for forked dependencies Sep 20, 2021
@ceyhun ceyhun mentioned this pull request Sep 20, 2021
Merged
4 tasks
@fluiddot fluiddot marked this pull request as ready for review September 27, 2021 12:15
@fluiddot fluiddot self-assigned this Sep 27, 2021
@fluiddot
Merge branch 'develop' into try/tarball-for-forks
8e97bb9 
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
@fluiddot fluiddot requested a review from hypest September 27, 2021 15:12
hypest
hypest approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluiddot fluiddot added this to the 1.63.0 (18.4) milestone Sep 28, 2021
@fluiddot fluiddot enabled auto-merge September 28, 2021 09:39
@fluiddot fluiddot merged commit 650ee9b into develop Sep 28, 2021
@fluiddot fluiddot deleted the try/tarball-for-forks branch September 28, 2021 09:44
@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@fluiddot fluiddot

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.63.0 (18.4)
Development

Successfully merging this pull request may close these issues.
3 participants
@ceyhun @hypest @fluiddot