Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to keep or replace Featured Image when replacing Image block media that is set as the Featured Image #3930

Merged
merged 20 commits into from
Feb 2, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Sep 8, 2021

Related PRs

Related to WordPress/gutenberg#34429. If an Image block is set as the post's Featured Image, replacing the Image block's media will prompt the user as to whether they want to replace the Featured Image as well.

To test: See WordPress/gutenberg#34666.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun force-pushed the feature/image-block-replace-featured-image-prompt branch from 464b384 to cdd60f3 Compare September 9, 2021 14:18
@dcalhoun dcalhoun added this to the 1.62.0 (18.3) milestone Sep 9, 2021
@dcalhoun dcalhoun marked this pull request as ready for review September 9, 2021 16:15
@dcalhoun dcalhoun requested a review from SiobhyB September 9, 2021 16:16
@jd-alexander
Copy link
Contributor

Hey @dcalhoun .We will cut the 1.62.0 release today so I am bumping this PR to the next milestone. Let me know if you’d rather us work to include this PR in 1.62.0. Thanks!

@twstokes
Copy link
Contributor

Hey @dcalhoun. We will cut the 1.63.0 release today. Please let me know if you’d like to bump this to the next milestone or rather us work to include this PR in 1.63.0. Thanks!

@dcalhoun dcalhoun modified the milestones: 1.63.0 (18.4), 1.64.0 (18.5) Sep 30, 2021
@dcalhoun
Copy link
Member Author

Thanks for the ping, @twstokes. I bumped this PR to the next release.

@geriux
Copy link
Contributor

geriux commented Oct 13, 2021

Hey @dcalhoun 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks!

@fluiddot
Copy link
Contributor

Hey @dcalhoun !
We will cut the 1.66.0 release on 2021-11-11. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.66.0. Thanks!

@fluiddot fluiddot modified the milestones: 1.66.0 (18.7), 1.67.0 (18.8) Nov 11, 2021
@SiobhyB
Copy link
Contributor

SiobhyB commented Nov 24, 2021

👋 @dcalhoun, we plan to cut the 1.67.0 release around 10:00 UTC tomorrow, on Thursday 25th November. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.67.0.

As a reminder, changes in the next (1.68.0) release won't be shipped to users until the 10th January.

Thanks!

@dcalhoun dcalhoun removed this from the 1.67.0 (18.8) milestone Nov 24, 2021
@dcalhoun dcalhoun added this to the 1.71.0 (19.2) milestone Jan 27, 2022
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34666 (review)

I only had one comment about what seems like an erroneous change to the translations, but nothing blocking!

bundle/android/strings.xml Show resolved Hide resolved
@mchowning
Copy link
Contributor

Hey @dcalhoun ! We plan to cut the 1.71.0 release at the start of the day on February 3. If this isn't merged before then, I'll circle back and bump this PR to the next milestone then, but let me know if you’d rather us work to include this PR in 1.71.0. Thanks!

@dcalhoun dcalhoun enabled auto-merge February 2, 2022 15:27
@dcalhoun dcalhoun merged commit f9333d8 into develop Feb 2, 2022
@dcalhoun dcalhoun deleted the feature/image-block-replace-featured-image-prompt branch February 2, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants