Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed block] Alignment options #3787

Merged
merged 7 commits into from
Sep 1, 2021
Merged

[Embed block] Alignment options #3787

merged 7 commits into from
Sep 1, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 3, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#33851

Fixes: #3284

To test:
Follow the testing instructions from gutenberg PR: WordPress/gutenberg#33851.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Aug 3, 2021
@fluiddot fluiddot mentioned this pull request Aug 3, 2021
Merged
7 tasks
@fluiddot fluiddot linked an issue Aug 3, 2021 that may be closed by this pull request
[Embed block] Alignment options #3284
Closed
Base automatically changed from embed-block-preview to develop August 11, 2021 15:38
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 12, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review August 18, 2021 16:20
@fluiddot fluiddot requested a review from ceyhun August 18, 2021 16:21
ceyhun
ceyhun approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33851. We'll need to update gutenberg reference after merging that PR to trunk.

@fluiddot fluiddot added this to the 1.61.0 (18.2) milestone Sep 1, 2021
@fluiddot fluiddot merged commit d127516 into develop Sep 1, 2021
@fluiddot fluiddot deleted the embed-block-alignment branch September 1, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.61.0 (18.2)
Development

Successfully merging this pull request may close these issues.

[Embed block] Alignment options
2 participants
@fluiddot @ceyhun