Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Inserter Block Search Styling #3731

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Update Inserter Block Search Styling #3731

merged 2 commits into from
Jul 16, 2021

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jul 16, 2021

Update inserter block search styling see WordPress/gutenberg#33237

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jhnstn jhnstn requested review from fluiddot and guarani July 16, 2021 15:47
@fluiddot
Copy link
Contributor

I'm wondering if we could change the PR's title to match the changes from the gutenberg PR, what do you think about changing it to Update Inserter Block Search Styling?

fluiddot
fluiddot approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33237 (review).

NOTE: Before merging this PR, we should verify that the Gutenberg reference points to the merge commit of WordPress/gutenberg#33237 in Gutenberg's trunk branch.

@jhnstn
Copy link
Member Author

jhnstn commented Jul 16, 2021

I'm wondering if we could change the PR's title

Oh geez, not sure I like how single commit PRs just grab the commit message by default . Thanks for catching that.

@jhnstn jhnstn changed the title Update gutenberg ref Update Inserter Block Search Styling Jul 16, 2021
@jhnstn jhnstn merged commit 455d33e into develop Jul 16, 2021
@jhnstn jhnstn deleted the update/mobile-inserter-block-search branch July 16, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@guarani guarani Awaiting requested review from guarani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhnstn @fluiddot