Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gutenberg submodule after merging master into mobile #371

Merged
merged 6 commits into from
Dec 13, 2018
Merged

Update gutenberg submodule after merging master into mobile #371

merged 6 commits into from
Dec 13, 2018

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Dec 13, 2018

Changes reside in the child PR.

To Test

Try on both iOS and android

  • Boot the app
  • Try switching from visual to html and back
  • Try moving blocks up and down
  • Try adding a new block of every type
  • Try splitting an existing block
  • Try adding a new block while an empty/replaceable block is selected
  • Try removing blocks
  • Try editing in blocks
  • Try undo/redo changes

@Tug Tug self-assigned this Dec 13, 2018
@Tug Tug requested a review from hypest December 13, 2018 11:24
@Tug Tug mentioned this pull request Dec 13, 2018
Merged
4 tasks
@hypest
Copy link
Contributor

hypest commented Dec 13, 2018

Just merged the Gutenberg-side branch, feel free to update this PR to point to the merge.

LGTM after that!

@Tug
Copy link
Contributor Author

Tug commented Dec 13, 2018

Awesome! Thanks a lot @hypest

@Tug Tug merged commit 6304235 into master Dec 13, 2018
@hypest hypest deleted the update/gutenberg-submodule branch December 13, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest Awaiting requested review from hypest

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @hypest