Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Onboarding: "The Basics" help section - Topics List UI #3702

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Jul 7, 2021

Gutenberg PR: WordPress/gutenberg#33240

Description

This PR is the first in a series of PRs to add the Editor onboarding basic help section defined in this ticket: WordPress/gutenberg#30626 and covers the following:

  • Adds the "Help" menu option to Gutenberg demo app on Android and iOS to make testing easier.
  • Adds the main help topics bottom sheet. Clicking these items will just log "onPress" to the console at this point. The sub-page displaying the contents of each help topic will be in a separate PR.
  • Added additional icons to the @wordpress/icons package where needed to match the designs.

To test

Follow the testing steps in the Gutenberg PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@AmandaRiu AmandaRiu added this to the 1.57.0 (17.8) milestone Jul 7, 2021
@AmandaRiu AmandaRiu requested a review from dcalhoun July 7, 2021 01:45
@AmandaRiu AmandaRiu marked this pull request as ready for review July 7, 2021 01:45
@ceyhun
Copy link
Contributor

ceyhun commented Jul 8, 2021

Hey @AmandaRiu 👋 We will cut the 1.57.0 release on July 8. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.57.0. Thanks!

@AmandaRiu AmandaRiu modified the milestones: 1.57.0 (17.8), 1.58.0 (17.9) Jul 8, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#33240 (review). We'll just need to update the gutenberg ref to the merge commit before merging this PR.

@AmandaRiu AmandaRiu merged commit d2dfc4c into develop Jul 15, 2021
@AmandaRiu AmandaRiu deleted the task/editor-onboarding-basic-help-2 branch July 15, 2021 23:46
@fluiddot fluiddot mentioned this pull request Jul 22, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants