Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash inserter - Improve E2E #3549

Merged
merged 6 commits into from
May 26, 2021
Merged

Slash inserter - Improve E2E #3549

merged 6 commits into from
May 26, 2021

Conversation

geriux
Copy link
Contributor

@geriux geriux commented May 25, 2021

Gutenberg PR -> WordPress/gutenberg#32186

To test, check the Canaries and the full tests pass correctly.

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label May 25, 2021
@geriux geriux marked this pull request as ready for review May 25, 2021 10:36
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 26, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux requested a review from fluiddot May 26, 2021 12:36
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#32186 (review).

I also checked the "UI tests - Canaries" and passed for both platforms 🟢 .

iOS Android
Screenshot 2021-05-26 at 16 36 42 Screenshot 2021-05-26 at 16 36 54

@geriux geriux merged commit e1d31a5 into develop May 26, 2021
@geriux geriux deleted the improve-slash-inserter-e2e branch May 26, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants