Exclude non-native files when extracting localization strings #3493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the case of extra strings of #3466.
Description
I added the following paths to the excluded argument of the
make:pot
commands, this way we prevent adding extra strings from non-native files.New excluded paths:
build/*
build-module/*
build-style/*
*.js
*.php
In theory, this change shouldn't be required because the
--include
argument should only include the specified paths, however, this is not working as expected.Besides, just by excluding
*.js
should only extract strings from*.native.js
files, unfortunately, it's not and it's including by default thebuild*
folders 🤷♂️ .To test
Extra strings are not added
npm run genstrings
Only extract strings from native files
npm run makepot:ios -- --debug
.native.js
files are being parsedNote: Some files are giving parse failures, this is caused by the use of the optional chaining operator that is not supported by the script that extracts the strings.
PR submission checklist: