Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update theme updates to use the approach that guarantees delivery #3376

Merged
merged 4 commits into from
Apr 15, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Apr 14, 2021

Fixes #3163
Related PRs:

📓 This PR can merge as soon as the Gutenberg PR merges but is independent of any of the other changes.

To test:

This can be tested by running the regression test suite:

- [ ] Default Colors - Check that default colors still load - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/editor-theme.md#tc001) 
- [ ] Default Gradients - Check that default gradients still load - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/editor-theme.md#tc002)
- [ ] Custom Colors - Check that custom colors load in the editor - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/editor-theme.md#tc003)
- [ ] Custom Gradients - Check that custom gradients load in the editor - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/editor-theme.md#tc004)
- [ ] Offline Support - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/editor-theme.md#tc005)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder
Copy link
Contributor Author

@dcalhoun @enejb CC'ing you two since you're the release wranglers for this release. This isn't required for 1.51 but I would like to get it merged for that release if possible. Added you as reviewers just so you're aware.

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#30847 🎉

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 15, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@chipsnyder chipsnyder merged commit d72683b into develop Apr 15, 2021
@chipsnyder chipsnyder deleted the issue/gss-3163-themeStore branch April 15, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants