Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg hash for fixing crash related to pasting formatted text #3359

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Gutenberg hash for fixing crash related to pasting formatted text #3359

merged 3 commits into from
Apr 9, 2021

Conversation

illusaen
Copy link
Contributor

@illusaen illusaen commented Apr 9, 2021 •
edited
Loading

Gutenberg: #30676
Fixes #30672

To test:

  • Copy formatted text
  • Paste formatted text, see no crash
  • Paste formatted text without formatting, also see no crash.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@illusaen illusaen requested a review from antonis April 9, 2021 15:14
@illusaen illusaen mentioned this pull request Apr 9, 2021
Merged
7 tasks
antonis
antonis approved these changes Apr 9, 2021
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#30676 (review) 🎉

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 9, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@illusaen illusaen merged commit df23686 into develop Apr 9, 2021
@illusaen illusaen deleted the fix-crash-pasting-formatted-text branch April 9, 2021 19:47
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: Android: Pasting formatted text crashes the editor
2 participants
@illusaen @antonis