a11y: Screenreader improvements to the UnitControl component #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dcalhoun
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Reviewed and approved via WordPress/gutenberg#29741 (review). We just need to resolve merge conflicts and update the gutenberg reference to be the merge commit before merging this PR.
…ents # Conflicts: # gutenberg
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WordPress/gutenberg#29359 and additionally improves on both the Range and Stepper views of the
UnitControlcomponent for both TalkBack and VoiceOver mobile screenreaders.Gutenberg PR: WordPress/gutenberg#29741
To Test
see the testing instructions in the Gutenberg PR.
PR submission checklist: