Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Bottom-sheet height after using back button #3080

Merged
merged 2 commits into from
Feb 1, 2021
Merged

[FIX] Bottom-sheet height after using back button #3080

merged 2 commits into from
Feb 1, 2021

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Feb 1, 2021

Fixes the issue with the height of bottom-sheet when we back from another screen inside it.

GB PR: WordPress/gutenberg#28632

To test:

  1. add button block
  2. open settings
  3. open the background color settings
  4. select gradient segment
  5. open "customize gradient"
  6. use the back button on the top left of bottom-sheet
  7. switch to solid segment
  8. switch back to the gradient segment
  9. the height should be changed

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dratwas dratwas requested a review from lukewalczak February 1, 2021 16:41
lukewalczak
lukewalczak approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#28632

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dratwas dratwas merged commit a7ffea7 into develop Feb 1, 2021
@dratwas dratwas deleted the fix/bottom-sheet-height branch February 1, 2021 17:49
@fluiddot
Copy link
Contributor

fluiddot commented Feb 2, 2021

👋 @dratwas since this is going to be included in version 1.46.0, I've just assigned the PR to the version milestone.

@fluiddot fluiddot added this to the 1.46 (16.7) milestone Feb 2, 2021
@fluiddot fluiddot mentioned this pull request Feb 2, 2021
Merged
3 tasks
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46 (16.7)
Development

Successfully merging this pull request may close these issues.
3 participants
@dratwas @fluiddot @lukewalczak