-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump GB hash and update package-lock.json, plus fix Memory issue on CI #2960
Conversation
All tests green except the Correctness check, which failed with more changes detected in |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
After removing and re-adding Tried using Finally I managed to resolve all the packages with eslint-import-resolver-node, by adding But all the errors were now Side note: Seems like both the rules are disabled for React Native code in Gutenberg. |
4f3f994
to
3cc6740
Compare
Not sure why but when I run |
This happened some time ago, but doesn't happen anymore. I think it could be related to node/npm version mismatch. Can you please try again after running |
I've cleared the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I'm getting the import/no-unresolved
error again, however before the latest changes it was working, @ceyhun are you getting it too?
By the way, I saw that one of the PR checks Check Correctness
is failing, looks like the machine that is running the process runs out of memory 🤔 :
Error: ENOMEM: not enough memory, read
I've run |
Did you try running
I saw it too, this could be a problem :( To debug it I rerun the job with SSH, but it passed this time. It means that this job could be flaky. I would like to reproduce this again and then solve it for good. |
Good point!. Yeah I think that was the cause of the issue indeed because if I run |
This might need another look now @fluiddot. Managed to fix the memory error by using |
Good job! I'll re-run them one more time to double check. I was checking the environment used in Gutenberg PR checks for building the packages and I saw that there we're using GitHub hosted runners which have 7 GB of RAM so probably we need that amount of RAM for this process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check Correctness
check passed 🎊 !
PR to bump the Gutenberg submodule hash and update the
package-lock.json
file, mitigating the lock file issue spotted by the Dependabot PR.To test:
PR submission checklist: