Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract duplicate e2e test setup to jest config #2846

Merged
merged 14 commits into from
Dec 16, 2020
Merged

Extract duplicate e2e test setup to jest config #2846

merged 14 commits into from
Dec 16, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Nov 27, 2020 •
edited
Loading

See Gutenberg PR for more information: WordPress/gutenberg#27334

To test:

  • CI: Full E2E Test suite should pass
  • Locally: npm run test:e2e:ios:local and npm run test:e2e:android:local should work as before.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the Testing Anything related to automated tests label Nov 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 27, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun mentioned this pull request Nov 30, 2020
Merged
6 tasks
@ceyhun ceyhun marked this pull request as ready for review November 30, 2020 18:09
@ceyhun ceyhun mentioned this pull request Nov 30, 2020
Merged
2 tasks
cameronvoell
cameronvoell approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

@ceyhun ceyhun merged commit d898415 into develop Dec 16, 2020
@ceyhun ceyhun deleted the try/new-jest-config branch December 16, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceyhun @cameronvoell