Stories block: hide/show based on Editor capability settings being set, only after it's been loaded #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when editor settings has already been loading
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
etoledom
approved these changes
Nov 3, 2020
| return select( 'core/block-editor' ).getSettings( 'capabilities' ) | ||
| .mediaFilesCollectionBlock; | ||
| }, [] ); | ||
| // eslint-disable-next-line @wordpress/react-no-unsafe-timeout |
There was a problem hiding this comment.
Maybe we could write down the reason why are we using a timeout here too for future references
There was a problem hiding this comment.
Good idea! added here 6eb17d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed the settings may not be ready exactly when the
native.renderhooks get run but rather right after that execution cycle. Hence, we're only checking for the actual settings to be loaded by usingsetTimeoutwithout delayTo test:
npm run test src/test/index.jsNote: I've considered and tried adding unit tests for the specific functionality added but, since we haven't found a way to mock select/dispatch easily yet - will get back at this at a later point.
PR submission checklist: