Move the setupJetpackEditor() call order #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
mzorz
requested review from
etoledom and
jd-alexander
and removed request for
hypest
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
etoledom
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the order in which the jetpack blocks get registered from
'native.pre-render'action to'native.render'action, with the aim of having the jetpack blocks listed last in the block picker as per default (and let core blocks be first with the default order at first). Note the order in which they appear may be subject to change later on a per user basis, depending on the frecency calculations when getting items from the store to the inserter.Before
See the jetpack blocks (Contact info, Story) appear first
After
See the jetpack blocks (Contact info, Story) appear last