Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Story block rendering (part 4): error handling #2708

Merged
merged 10 commits into from
Oct 22, 2020
Merged

Add support for Story block rendering (part 4): error handling #2708

merged 10 commits into from
Oct 22, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Oct 11, 2020 •
edited
Loading

This PR builds on top of #2706

Related PRs:

WPAndroid: wordpress-mobile/WordPress-Android#13103
Gutenberg: WordPress/gutenberg#26008
Jetpack: Automattic/jetpack#17458

To test:

  • see the WPAndroid PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Oct 11, 2020
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 12, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mzorz mzorz marked this pull request as ready for review October 14, 2020 13:43
Base automatically changed from try/jetpack-stories-block-on-done-refactor to try/jetpack-stories-block-on-done October 14, 2020 14:59
Base automatically changed from try/jetpack-stories-block-on-done to try/jetpack-stories-block October 14, 2020 16:58
etoledom
etoledom approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#26008 (review) and Automattic/jetpack#17458 (review)

Keep in mind we still need a ✅ for the Android native side on WordPress/gutenberg#26008 before merging (cc @jd-alexander 🙏 )

jd-alexander
jd-alexander approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is well on the Android side. I am going to be reviewing the unit tests that were just added after my initial approval.

@jd-alexander jd-alexander self-requested a review October 22, 2020 01:34
@mzorz mzorz merged commit fdbb451 into try/jetpack-stories-block Oct 22, 2020
@mzorz mzorz deleted the try/jetpack-stories-block-error-handling branch October 22, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@guarani guarani Awaiting requested review from guarani

@jd-alexander jd-alexander Awaiting requested review from jd-alexander

Assignees
No one assigned
Labels
Story block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzorz @jd-alexander @etoledom