Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block inserter accessibility #2655

Merged
merged 8 commits into from
Oct 14, 2020

Conversation

jd-alexander
Copy link
Contributor

Fixes #915
Improves accessibility of the Inserter.

To test:
See WordPress/gutenberg#25549
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 23, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander marked this pull request as ready for review September 23, 2020 19:39
@etoledom
Copy link
Contributor

etoledom commented Oct 1, 2020

Hey @jd-alexander !

It seems this branch needs to be updated with develop. I experienced an issue fixed by this PR: #2662

This is probably why CI is failing too.

Please let me know when it's ready! 🙏

@jd-alexander jd-alexander requested a review from etoledom October 9, 2020 02:15
@etoledom
Copy link
Contributor

etoledom commented Oct 9, 2020

Hey @jd-alexander - I was talking a look to these CI errors. The failure from the. PR changes have definitely be fixed already 🎉

What I noticed is that the gutenberg side branch doesn't seem to be updated yet.
I'd recommend you to rebase that branch from origin/master (there seems to be a conflict there even, I tried locally). And then update once again the reference on this PR.

Having an updated gutenberg-mobile and an outdated gutenberg branch sounds like might arise problems.

This is what the Android UI Test look like on CI (not very helpful to me though):

Screenshot 2020-10-09 at 10 13 47

@jd-alexander
Copy link
Contributor Author

Thanks much for your help @etoledom I will definitely follow these steps from now to ensure everything is in sync 🙏

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander merged commit cf06fd7 into develop Oct 14, 2020
@jd-alexander jd-alexander deleted the issue-915/improve_block_inserter_accessibility branch October 14, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Screen Reader support for Block Picker.
2 participants