Update release automation script to create WPiOS and WPAndroid PRs #2554
Conversation
| cd .. | ||
|
|
||
| # Set version numbers | ||
| for file in 'package.json' 'package-lock.json' 'gutenberg/packages/react-native-editor/package.json'; do | ||
| npx json -I -f "$file" -e "this.version='$VERSION_NUMBER'" || { echo "Error: could not update version in ${file}"; exit 1; } |
There was a problem hiding this comment.
We may be able to remove the json dependency from the package.json file now.
|
|
||
| # Ask for new version number | ||
| CURRENT_VERSION_NUMBER=$(./node_modules/.bin/json -f package.json version) | ||
| CURRENT_VERSION_NUMBER=$(jq '.version' package.json --raw-output) |
There was a problem hiding this comment.
Might be worth adding an early check that jq is available so that if it's not available the script can abort with a clear error message.
|
Really like these improvements! 😄 The only thought I really have is that it might be nice to add some documentation to the new utility functions that are being added. At least for me, it was far from obvious what, for example, "execute" was used for. I'm far from a bash expert, so some of that is on me, but I feel like it might be nice to just add a bit of context for those methods. |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Sure! I'll add some "docs" as comments to top of the functions 👍 |
Here are the changes made to the script
To test:
PR submission checklist: