[FIX][Android] E2E tests - swipe inserter instead of sending the keycode 20 #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
dratwas
force-pushed
the
tmp/ci-tests-flatlist
branch
from
047ec0d to
71838fa
Compare
dratwas
changed the title
This reverts commit a393ebd.
6 tasks
ceyhun
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR WordPress/gutenberg#24338
Fixes Failing CI e2e test. Android e2e tests started failing after removing the scroll view from the inserter menu. I couldn't reproduce it on my side but I could fix that by using swipe gesture instead of sending the keycode 20 (arrow down).
I created the same Simulator as on Sauce Labs, used the same version of Appium and tests were passing on my side. I also tried to send locally keyevent by
adb shell input keyevent 20and that also works. However, I used the mechanism from here https://github.com/WordPress/gutenberg/pull/24338/files#diff-34060c7868e5c5d05b0a7f37b80fd440R453 that simulates the swipe gesture and now tests pass.To test:
PR submission checklist: