Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Release docs #2519

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Tweak Release docs #2519

merged 2 commits into from
Jul 29, 2020

Conversation

mchowning
Copy link
Contributor

This PR:

  1. Updates the release PR template to include to include a link to the related PR for each change in the release; and
  2. Adds a step to the "Specific tasks after a PR has been merged after the freeze" portion of the release checklist for adding any release updates to the "Extra PRs that Landed After the Release Was Cut" section of the gb-mobile release PR.

To test:
Make sure the updates make sense.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@mchowning mchowning added this to the 1.34 milestone Jul 28, 2020
@mchowning mchowning requested a review from SergioEstevao July 28, 2020 21:22
SergioEstevao
SergioEstevao approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mchowning mchowning merged commit 1b8c4f7 into develop Jul 29, 2020
@mchowning mchowning deleted the update_release_pr_template branch July 29, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @SergioEstevao