Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release script to push gutenberg release branch #2517

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 28, 2020

Updating the release script to push the gutenberg release branch. I think we should do this because we update the gutenberg branch with the version number and the updated submodule hash is committed to gb-mobile release branch, but the referenced commit won't be pushed to the gb repository unless/until it is manually pushed. Until that is done no one else would be able to build the release branch.

To test:
Verify that the release script will push the gb branch.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning added this to the 1.34 milestone Jul 28, 2020
@mchowning mchowning requested a review from SergioEstevao July 28, 2020 19:22
@mchowning mchowning mentioned this pull request Jul 28, 2020
2 tasks
@mchowning
Copy link
Contributor Author

👋 @SergioEstevao ! I'm inclined to update this PR to go further and just make a gutenberg PR as well. WDYT?

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement.
As a follow up we should consider opening a PR too, we probably can add a custom template to there.

@mchowning mchowning merged commit 51a262a into develop Jul 29, 2020
@mchowning mchowning deleted the update_release_script_to_push_gb branch July 29, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants