Cover block - Hide media editing button for videos #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
antonis
approved these changes
Jul 24, 2020
added 2 commits
July 24, 2020 13:20
# Conflicts: # gutenberg
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#24189After merging media editing support for Cover block it introduced a regression with videos, showing the media edit button when it shouldn't.
To test check the Gutenberg PR description.
PR submission checklist:
[RELEASE-NOTES.txt](RELEASE-NOTES.txt)if necessary.