Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cover block with custom colour (without an image) #2508

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Create cover block with custom colour (without an image) #2508

merged 4 commits into from
Jul 27, 2020

Conversation

antonis
Copy link

@antonis antonis commented Jul 24, 2020

Fixes WordPress/gutenberg#23868 (parent #2275)

Related PRs:

Description

Please refer at WordPress/gutenberg#23870

To test:

Cover block creation with custom colour

  • Add a cover block
  • Press the one custom colour from the palette
  • Verify that the custom colour picker appears
  • Select a colour and press apply
  • Verify that a new cover block with only colour is created

Canceling the cover block creation

  • Add a cover block
  • Press the one custom colour from the palette
  • Verify that the custom colour picker appears
  • Select a colour and press cancel
  • Verify that the block remains in the original state

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 24, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis added this to the 1.34 milestone Jul 24, 2020
@antonis antonis added [Type] Enhancement Improves a current area of the editor App Integration Blocks labels Jul 24, 2020
@antonis antonis self-assigned this Jul 24, 2020
@antonis antonis mentioned this pull request Jul 24, 2020
Merged
6 tasks
@antonis antonis changed the title Gutenberg reference update Create cover block with custom colour (without an image) Jul 24, 2020
@antonis antonis requested a review from geriux July 24, 2020 11:04
geriux
geriux approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#23870 (review)

@antonis antonis merged commit 7dce390 into wordpress-mobile:develop Jul 27, 2020
@antonis antonis mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@antonis antonis

Labels
App Integration Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @geriux