-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove willTrimSpaces check on Android #2206
Conversation
I added an e2e test to cover this scenario. I'm a bit torn on whether that's a good idea or not. On one hand these out of bounds issues have been a recurrent issue on Android, but on the other hand it seems like a bit of an edge case and if we added e2e tests for every one of these our test suite would take forever to run (admittedly we're a long ways from having that problem). Interested to hear your thoughts. |
165c939
to
054ad21
Compare
👋 @hypest ! Could you take a look at this PR? I believe you have the most experience with the |
Had a look and left a comment Matt. I think that it's OK to remove the In the meantime, tried the original issue and still works OK on this PR. |
@mchowning do you still want this to go for 1.28? |
No, better to bump it. |
Switching this to be a draft for the time being because I think I'll be submitting a larger change shortly that will include this. |
Closing this because these changes were already handled in #2279 |
Removes willTrimSpaces check on Android. See PR description and testing steps in WordPress/gutenberg#22006.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.