Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre block style to use monospace font. #2083

Merged
merged 10 commits into from
Apr 1, 2020
Merged

Fix pre block style to use monospace font. #2083

merged 10 commits into from
Apr 1, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 30, 2020 •
edited by hypest
Loading

Fixes #2081

Gutenberg PR: WordPress/gutenberg#21255

To test:

  • Start the demo app
  • Check the preformatted blocks are using a monospace font.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Web breakage Caused by incompatible changes on Gutenberg web label Mar 30, 2020
@SergioEstevao SergioEstevao requested a review from hypest March 30, 2020 13:59
@SergioEstevao SergioEstevao mentioned this pull request Mar 31, 2020
Merged
6 tasks
etoledom
etoledom approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#21255 (review)
Thank you @SergioEstevao !

@SergioEstevao SergioEstevao added this to the 1.25 milestone Mar 31, 2020
@SergioEstevao SergioEstevao mentioned this pull request Mar 31, 2020
Merged
4 tasks
@SergioEstevao SergioEstevao merged commit 4783f25 into develop Apr 1, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_pre_style branch April 1, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.

PRE (Preformatted) Block doesn't have monospace font
2 participants
@SergioEstevao @etoledom