-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1675 dark mode android integration #2061
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
marecar3
changed the title
Feature/1675 dark mode android integration new
Feature/1675 dark mode android integration
Mar 25, 2020
Closed
3 tasks
Marking this one with DO NOT MERGE flag until we don't resolve this blocker: #2056 |
…n_new # Conflicts: # gutenberg
…n_new # Conflicts: # gutenberg
@marecar3 I'm moving this to 1.26, feel free to move it back to 1.25 if this is something that can be considered a regression. |
2 tasks
We'll try to target 1.25 with this after all so, changing the milestone accordingly. |
Closing in favor: #2098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1675
Gutenberg PR: WordPress/gutenberg#21139
WordPress-Android PR: wordpress-mobile/WordPress-Android#11498
To test:
On devices with API <=28:
Set by Battery Saver
.Dark
and confirm that the app switches to Dark Theme.Light
and confirm that the app switches to Light Theme.Set by Battery Saver
and enable Battery Saver on the device.On devices with API 29+:
System Default
.Dark
and confirm that the app switches to Dark Theme.Light
and confirm that the app switches to Light Theme.System Default
and close the app.Note for API 29+: At this moment we aren't able to get the app theme to switch automatically when the Dark Theme is toggled. For now, you need to restart the app for new theme to take effect. @khaykov has created a separate issue for this at wordpress-mobile/WordPress-Android#10748
PR submission checklist:
RELEASE-NOTES.txt
if necessary.