Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1675 dark mode android integration #2061

Closed

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Mar 25, 2020

Fixes #1675

Gutenberg PR: WordPress/gutenberg#21139
WordPress-Android PR: wordpress-mobile/WordPress-Android#11498

ezgif com-video-to-gif (13)

To test:

On devices with API <=28:

  1. Open App Settings from Me screen.
  2. Notice the App Theme preference.
  3. The default value should be set to Set by Battery Saver.
  4. From the preference, dialog select Dark and confirm that the app switches to Dark Theme.
  5. Open the Gutenberg Editor and confirm that it has Dark Theme
  6. Select Light and confirm that the app switches to Light Theme.
  7. Open the Gutenberg Editor and confirm that it has Light Theme
  8. Select Set by Battery Saver and enable Battery Saver on the device.
  9. Confirm that Dark Theme is used when Battery Saver is ON.

On devices with API 29+:

  1. Open App Settings from Me screen.
  2. Notice the App Theme preference.
  3. The default value should be set to System Default.
  4. From the preference, dialog select Dark and confirm that the app switches to Dark Theme.
  5. Open the Gutenberg Editor and confirm that it has Dark Theme
  6. Select Light and confirm that the app switches to Light Theme.
  7. Open the Gutenberg Editor and confirm that it has Light Theme
  8. Select System Default and close the app.
  9. Enable Dark Theme in Display settings of the device.
  10. Launch the app again and confirm that the dark theme is applied.

Note for API 29+: At this moment we aren't able to get the app theme to switch automatically when the Dark Theme is toggled. For now, you need to restart the app for new theme to take effect. @khaykov has created a separate issue for this at wordpress-mobile/WordPress-Android#10748

PR submission checklist:

  • replace "future release" in release notes with some version
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added this to the 1.25 milestone Mar 25, 2020
@marecar3 marecar3 changed the title Feature/1675 dark mode android integration new Feature/1675 dark mode android integration Mar 25, 2020
@marecar3 marecar3 added the [Status] DO NOT MERGE Do not merge this PR label Mar 26, 2020
@marecar3
Copy link
Contributor Author

Marking this one with DO NOT MERGE flag until we don't resolve this blocker: #2056

@SergioEstevao
Copy link
Contributor

@marecar3 I'm moving this to 1.26, feel free to move it back to 1.25 if this is something that can be considered a regression.

@SergioEstevao SergioEstevao modified the milestones: 1.25, 1.26 Mar 31, 2020
@hypest
Copy link
Contributor

hypest commented Apr 2, 2020

We'll try to target 1.25 with this after all so, changing the milestone accordingly.

@hypest hypest modified the milestones: 1.26, 1.25 Apr 2, 2020
@marecar3
Copy link
Contributor Author

marecar3 commented Apr 3, 2020

Closing in favor: #2098

@marecar3 marecar3 closed this Apr 3, 2020
@marecar3 marecar3 deleted the feature/1675-dark_mode_android_integration_new branch April 3, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode - Android integration
3 participants