Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to RN 0.62-rc0 #1723

Closed
wants to merge 66 commits into from
Closed

Update to RN 0.62-rc0 #1723

wants to merge 66 commits into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Dec 24, 2019 •
edited
Loading

Draft PR to track the attempt to upgrade to RN 0.62

Currently based on the 0.61.x effort (#1704).

WIP

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

jtreanor and others added 30 commits October 11, 2019 10:08
@jtreanor
Update React Native to 0.61.2
6f0ec76
@jtreanor
Update podspecs for 0.61.2
91512f9
@jtreanor
Fix TextInputState import
08b581b
@jtreanor
Use unpatched react-native-svg since we are no longer using RN fork
3d670e9
@jtreanor
Update Gutenberg.podspec for RN 0.61.x
37dc045
@SergioEstevao
Update iOS project to use Cocoapods for all React dependencies
c9f1fa7
@SergioEstevao
Update project to use Swift 5
e963bfb
@SergioEstevao
Update build scripts for ios.
e7582c7
@jtreanor
Update generated podspec for RNSVG
6c82c54
@jtreanor
Add Gemfile to ensure we use a consistent version of CocoaPods
c305d5c
@jtreanor
Update dependencies cache to cache Bundler and CocoaPods
180efb9
@jtreanor
Update Gradle to 5.5 and Gradle Plugin to 3.4.2
1da1e1d
@jtreanor
Use Android 28
9ce7cd6
@jtreanor
Remove remaining references to react-native-recyclerview-list
00b022e
@jtreanor
Add org.wordpress:utils as dependency of react-native-gutenberg-bridge
08e3b32
@hypest
Upgrade react-native-modal to v11.4.0
535191d
@hypest
Whitespace adjustment
ba217a7
@hypest
Upgrade to react-native-svg 9.12.0
335034c
@hypest
Point to new react-native-svg 9.12.0 branch
9a58dd2 
That branch has more clear commit history of what was updated from
upstream and what got manually modified.
@hypest
Revert "Fix Android device tests for AndroidX migration (#1125)"
ae8c383 
This reverts commit 82de3b6.
@hypest
Revert "Upgrade react-native-modal to v11.4.0"
f2f5b94 
This reverts commit 535191d.
@hypest
Update Podfile.lock
5fb9eb8
@hypest
Merge branch 'develop' into update-rn-0-61
3157886
@hypest
Fix test snapshot
3687f85
@SergioEstevao
Update subprojects references.
31666e9
@SergioEstevao
Update aztec version number to be explicit.
8fdd471
@SergioEstevao
No need to specific Aztec here because it come from RNTAztecView pod.
2172afe
@SergioEstevao
Update lock file.
72d11b2
@SergioEstevao
Remove explicit dependency of Aztec.
dfe9687
@SergioEstevao
Update package version to force podfile update in CircleCI
73408e6
hypest added 22 commits December 16, 2019 17:52
@hypest
Update Gutenberg hash
f7075ee
@hypest
Update Gutenberg ref
eed6c13
@hypest
Update Gutenberg ref
23ef941
@hypest
Try to match a default RN 061 app
0a0cfee
@hypest
Some more updates
0a88d79
@hypest
Don't force resolve rn/cli
c808857
@hypest
Needs commas
f08eb6e
@hypest
Match the allowBackup value from WordPress-Aztec-Android:glide-loader
679de7b
@hypest
Using the Hermes binary
7dd0dfe
@hypest
Upgrade react-native-svg to 9.13.6-gb
c4873c9
@hypest
Replace the removed leftShift gradle operator
722e875
@hypest
Keep Hermes AARs around after node_modules cleanup, to use while buil…
ec6c216 
…ding android bridge
@hypest
Let's try building on JitPack without installing SDKs manually
403b858
@hypest
Log the Hermes state
3e6e104
@hypest
Set the Hermes executor factory. Not sure if really needed
e979814
@hypest
Upgrade react-native-video to 5.0.1
1282f76
@hypest
Bump the bridge RN dep to 0.61.5 too
20ccb07
@hypest
Remove some refs to JSC
300f8da
@hypest
Dep on Hermes only in the bridge lib
9be1794
@hypest
Update React and React Native via yarn add
0bac353
@hypest
Update gradle setup
0588428
@hypest
Update flow
3299d72
@Tug
Copy link
Contributor

Tug commented Jan 21, 2020

@hypest: @dratwas brought to my attention that this PR will be particularly hard to bring to gutenberg as part of the monorepo effort.

Given the amount of changes here, our best hope could be to just copy and paste the android and ios folders into their respective folders and commit the changes in gutenberg. We'll lose history but it's probably better than the rebase hell we'll get from pulling the subtree. But then I'm also worried that it will prevent us from bringing other (simpler) changes in because of that.

@hypest
Copy link
Contributor Author

hypest commented Jan 24, 2020

Thanks for the headsup @Tug ! Let's revisit when the 0.62 upgrade reaches a more mature state. For the time being, this looks like more work is needed anyway.

@SergioEstevao
Copy link
Contributor

@hypest I think it will be better to start with a clean slate, there is a lot of noise on this PR no?

@SergioEstevao SergioEstevao marked this pull request as ready for review January 27, 2020 12:08
@hypest
Copy link
Contributor Author

hypest commented Jan 27, 2020

@hypest I think it will be better to start with a clean slate, there is a lot of noise on this PR no?

Fine by me! Feel free to close if it makes more sense to you @SergioEstevao 👍

@marecar3
Copy link
Contributor

Closing this one in favor of #1823

@marecar3 marecar3 closed this Jan 27, 2020
@SergioEstevao SergioEstevao deleted the update-rn-0-62-rc0 branch April 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hypest @Tug @SergioEstevao @marecar3 @jtreanor