Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate options for capturing photo and video #1579

Merged
merged 7 commits into from
Nov 15, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Nov 14, 2019

Description

This PR adds separate options for capturing a photo or a video for the media-text block.

Fixes: #1571

Related PRs:

gutenberg: WordPress/gutenberg#18505

How has this been tested?

I've tested this out via WordPress-Android develop: 8088889a2992d75bed0a9ac7ef042b83b53b654a

To test:

Steps:

  1. Create a post in WordPress-Android (and WordPress-iOS)
  2. Add "Media & Text" block
  3. Click on it
  4. Choose "Take a photo or video"

Expected:

  • Separate options should exist for "Take a Photo" and "Take a Video"
  • These options should work as expected and bring you to the relevant camera.
  • After capturing a photo or video (video on sites that allow it), the file should upload and be displayed in the block.

@etoledom etoledom force-pushed the fix/media-text-capture-options branch from 722dc1c to 4d91b76 Compare November 14, 2019 16:37
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom etoledom merged commit 6c9d52e into release/1.17 Nov 15, 2019
@etoledom etoledom deleted the fix/media-text-capture-options branch November 15, 2019 09:56
@hypest hypest mentioned this pull request Nov 15, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants