Add native fullscreen image preview #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for fullscreen preview on Android
… Android Native side.
…android-media-preview-activity
cameronvoell
changed the title
6 tasks
cameronvoell
added
Aztec Parity
… while image is uploading or failed to upload.
hypest
approved these changes
Nov 14, 2019
hypest
deleted the
add/mobile-fullscreen-image-preview-android-media-preview-activity
branch
cameronvoell
commented
Nov 14, 2019
.gitmodules
Outdated
| @@ -1,6 +1,6 @@ | |||
| [submodule "gutenberg"] | |||
| path = gutenberg | |||
| url = ../../cameronvoell/gutenberg.git | |||
| url = ../../WordPress/gutenberg.git | |||
There was a problem hiding this comment.
thanks for updating this!
There was a problem hiding this comment.
The failing CI jobs helped me remember it 😆
This was referenced Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1286
This PR adds a native method call for fullscreen image previews, for now Android only.
Related PRs:
To test:
To test on Android refer to WPAndroid PR: wordpress-mobile/WordPress-Android#10714
*Note this branch is pointing to cameronvoell gutenberg repo until WordPress/gutenberg#18493 is merged. ✅ Done c8cee10.
Update release notes:
RELEASE-NOTES.txt.