Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/fix paste in title #1575

Merged
merged 6 commits into from
Nov 14, 2019
Merged

Issue/fix paste in title #1575

merged 6 commits into from
Nov 14, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 13, 2019 •
edited by hypest
Loading

Addresses #624 (comment)

Fix copy paste on post title.

GB PR: WordPress/gutenberg#18479

To test:

  • Try to copy paste some content on the post title.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Nov 13, 2019
@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 13, 2019
@SergioEstevao SergioEstevao changed the base branch from develop to release/1.17 November 13, 2019 14:30
@hypest
Copy link
Contributor

hypest commented Nov 13, 2019

I confirm that this fixes the issue in my tests.

Before we land this, it seems that the Gutenberg side PR needs rebasing to clean it up and target rnmobile/release-v1.17.0 instead of master.

@SergioEstevao
Copy link
Contributor Author

@hypest rebase done!

@SergioEstevao SergioEstevao mentioned this pull request Nov 13, 2019
Merged
6 tasks
@SergioEstevao SergioEstevao requested a review from maxme November 14, 2019 10:38
@hypest
Copy link
Contributor

hypest commented Nov 14, 2019

Took the liberty to updated from the release/1.17 branch again since it now includes this fix that helps me test things on Android (otherwise wasabiDebug is crashing on my side)

hypest
hypest approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested via WPiOS too and works OK.

@SergioEstevao SergioEstevao merged commit 4016b94 into release/1.17 Nov 14, 2019
@SergioEstevao SergioEstevao deleted the issue/fix_paste_in_title branch November 14, 2019 13:57
This was referenced Nov 14, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@mkevins mkevins Awaiting requested review from mkevins

@maxme maxme Awaiting requested review from maxme

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @hypest