Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of GB master. #1548

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 6, 2019

Update develop branch to have the latest version of GB master.

Includes #1507 too, for which the GB ref bump was missed somehow.
Also includes WordPress/gutenberg#17937, with which we hope we address wordpress-mobile/WordPress-iOS#11950.

To test:

  • Just smoke test the demo app to see if all is running.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 6, 2019
@SergioEstevao SergioEstevao requested a review from hypest November 6, 2019 12:54
@hypest
Copy link
Contributor

hypest commented Nov 6, 2019

👋 @SergioEstevao , do you perhaps have a scenario that we can trigger wordpress-mobile/WordPress-iOS#11950 (comment)? It'd be good to test it while in this PR since it includes the GB side fix (WordPress/gutenberg#17937).

@SergioEstevao
Copy link
Contributor Author

So the one I detected was in my preformatted PR where a block used a RichText component and didn't set the 'identifier' prop to a correct value. When you tried to merge a block that didn't have the prop set you would get an exception.

But if all blocks have the identifier set properly I don't think you will be able to reproduce any longer.
Unless you remove the identifier in one of the blocks explicitly, for example in the paragraph block.

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By the way, I updated the PR description to include a mention to Danilo's
PRand Ella's .multiline attribute fix, for future reference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants