Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate unsupported blocks from unavailable #51

Open
4 tasks
koke opened this issue May 31, 2018 · 5 comments
Open
4 tasks

Differentiate unsupported blocks from unavailable #51

koke opened this issue May 31, 2018 · 5 comments

Comments

@koke
Copy link
Member

koke commented May 31, 2018

Turning unrecognized blocks (markup that doesn’t match any of the registered blocks) is the easy part. We also need to identify which blocks are available on the server but don't have a mobile implementation yet.

When the block doesn't exist on the server, we should use a UI similar to the one in WordPress/gutenberg#8274 saying that the site doesn't support that block.

However when it's just not supported on mobile the UI should be different.

To avoid confusion, let's use this terminology unless/until we agree on a new one:

  • Unregistered block: A block that has valid syntax but it's not registered on the server (e.g. a block provided by a plugin that was uninstalled)
  • Unsupported block: A block that is valid on the server and will render correctly, but doesn't have a working mobile implementation.

Right now I anticipate we'll need:

@koke koke changed the title Unsupported: [spike] Capture errors loading blocks that aren’t ported yet and turn those into unsupported Differentiate unsupported blocks from unavailable Oct 15, 2018
@koke koke added this to the Beta milestone Oct 15, 2018
@diegoreymendez
Copy link
Contributor

I'd suggest the API thing should go first, since it's basically a requirement to implement this feature.

@koke
Copy link
Member Author

koke commented Oct 23, 2018

@hypest do you know if there is such an API? Can we make that happen so it's ready for Q1?

@koke
Copy link
Member Author

koke commented Oct 30, 2018

The API (WordPress/gutenberg#4116) is not ready yet, and I can't bet sure it will be in 5.0. I don't think there's much to do here if we can't differentiate so I'm postponing this one until we have an API, and we'll just improve styling of the existing unsupported block.

@koke koke modified the milestones: Beta, Future Oct 30, 2018
@hypest
Copy link
Contributor

hypest commented Oct 30, 2018

so I'm postponing this one until we have an API

Sorry I missed the ping earlier. This sounds good to me 👍

hypest pushed a commit that referenced this issue Nov 2, 2018
…n_of_change_events

Improve propagation of change events
@hypest
Copy link
Contributor

hypest commented Jun 9, 2020

Putting this on the Backlog and we can revisit if the (ongoing at the time of writing) "Unsupported Blocks Fallback" project is not helping with this. cc @iamthomasbishop

@hypest hypest removed this from the Future milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants