Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First paragraph block on new post has too much padding when not selected #2077

Closed
iamthomasbishop opened this issue Mar 27, 2020 · 1 comment · Fixed by #2095
Closed

First paragraph block on new post has too much padding when not selected #2077

iamthomasbishop opened this issue Mar 27, 2020 · 1 comment · Fixed by #2095

Comments

@iamthomasbishop
Copy link
Contributor

Note: I’ve only seen this very recently on internal test builds. It doesn’t exist (yet) on the main WP Internal Alpha or the other public betas. So it must be from a very recently merged change. // cc @pinarol

When creating a new post, the first empty paragraph block seems to have unwanted additional padding, pushing the placeholder text inward.

This extra padding goes away when you select the block or add any content.

image

To Reproduce
Steps to reproduce the behavior:

  1. Start a brand new post
  2. See the empty paragraph block placeholder text has too much padding.
    The placeholder text should be aligned to the same 16px key line as other blocks.

Smartphone (please complete the following information):

  • Device: iPhone 11 Pro,Android Pixel 4, iPad Pro

  • OS: iOS 13.3.1 (iPhone 11 Pro), Android 10 (Pixel 4), iPad OS 13.4 (iPad Pro)

  • Version: I’ve only seen this very recently on internal test builds. It doesn’t exist (yet) on the main WP Internal Alpha or the other public betas.

@jbinda
Copy link
Contributor

jbinda commented Apr 1, 2020

I have check this and it was probably introduced after merge new bordering logic and is also connected with fix replacing empty paragraph](#2077)

When we open new post we render first Paragraph in DefaultAppender. It is also wrapped with View which has padding of value 16px applied. After implement new bordering logic it seems it gets extra margin. Will raise PR soon because already fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants