Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with BlogDashboardPersonalizationService being used on the background thread #22335

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 5, 2024

BlogDashboardPersonalizationService has to be main thread confined because it directly triggers the updates in the UI.

To test:

  • Comment out if !service.hasPreference(for: .prompts) { to make sure the service triggers the update every time
  • Open the app with Xcode debugger attaches
  • Verify that Xcode doesn't throw a runtime error

Regression Notes

  1. Potential unintended areas of impact: My Site
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the Pending milestone Jan 5, 2024
@kean kean requested a review from momo-ozawa January 5, 2024 15:13
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22335-19e4234
Version23.9
Bundle IDorg.wordpress.alpha
Commit19e4234
App Center BuildWPiOS - One-Offs #8330
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22335-19e4234
Version23.9
Bundle IDcom.jetpack.alpha
Commit19e4234
App Center Buildjetpack-installable-builds #7353
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean modified the milestones: Pending, 24.0 Jan 5, 2024
@kean kean enabled auto-merge January 5, 2024 15:59
@kean kean merged commit 3431c32 into trunk Jan 5, 2024
23 checks passed
@kean kean deleted the fix/prompt-settings-background-thread branch January 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants