Fix rare crash when deleting posts #22277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22247
I'm not entirely sure what leads to the crash https://a8c.sentry.io/issues/4716966489/?project=1438083&referrer=github_integration but it seems to be due to the order of updates/notifications when
PostCoordinator
deletes the post object and sends the "object-did-update" notification at the same time. In order to address it, I simply removed the redundant "did-update" notification.To test:
(In Posts Lists)
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: