Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare crash when deleting posts #22277

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 22, 2023

Fixes #22247

I'm not entirely sure what leads to the crash https://a8c.sentry.io/issues/4716966489/?project=1438083&referrer=github_integration but it seems to be due to the order of updates/notifications when PostCoordinator deletes the post object and sends the "object-did-update" notification at the same time. In order to address it, I simply removed the redundant "did-update" notification.

To test:

(In Posts Lists)

  • Delete a post and verify that it gets deleted
  • Mock the request failure or turn the connection off and verify that the post cell shows and hides the "Deleting.." message during the deletion attempt

Regression Notes

  1. Potential unintended areas of impact: Post List
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.0 milestone Dec 22, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22277-18947f5
Version23.9
Bundle IDorg.wordpress.alpha
Commit18947f5
App Center BuildWPiOS - One-Offs #8311
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22277-18947f5
Version23.9
Bundle IDcom.jetpack.alpha
Commit18947f5
App Center Buildjetpack-installable-builds #7335
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa self-assigned this Dec 28, 2023
@momo-ozawa momo-ozawa self-requested a review January 4, 2024 10:30
@kean kean force-pushed the fix/crash-when-deleting-posts branch from a8f4da3 to 18947f5 Compare January 4, 2024 16:35
@kean kean enabled auto-merge January 4, 2024 16:35
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ This PR is assigned to the milestone 24.0. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@kean kean merged commit 4002525 into trunk Jan 4, 2024
21 of 23 checks passed
@kean kean deleted the fix/crash-when-deleting-posts branch January 4, 2024 17:17
@salimbraksa salimbraksa assigned kean and unassigned salimbraksa Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: PostListViewController.postCoordinatorDidUpdate
4 participants