Plans in Site Creation: Create functionality to add domain with a plan to a cart #21667

staskus · 2023-10-02T11:41:25Z

Fixes #21636
Related WordPress Kit PR: wordpress-mobile/WordPressKit-iOS#628

Description

Update Podfile to use updated cart methods Created functionality to add domain with a plan to a cart WordPressKit-iOS#628
Replace deprecated createTemporaryDomainShoppingCart and createPersistentDomainShoppingCart methods with a new createShoppingCart method
Create ShoppingCartService to use the new API
Rename DomainPurchasing... to SiteCreationPurchasing...
Introduce planId into the flow and into SiteCreator

In the future PRs, will be able to set planId: Int value of SiteCreator after the user selects the plan and the changes made here will allow the flow to finish with the checkout.

To test:

Checkout opens if plan selected

Before testing:

Manually set planId: Int? value to 1009 in SiteCreator.swift

Enable Plans in Site Creation feature flag
Select Site Picker
Create new WordPress.com site
Select a free or paid domain
Finish creating a site
Confirm that plan exists in the cart

Video - paid domain

Plan.Purchase.with.Paid.Domain.mp4

Video - free domain

Plan.Purchase.with.Free.Domain.mp4

Regression

Disable Plans in Site Creation & Domain Purchasing in Site Creation (if still exists) feature flags
Select Site Picker
Create new WordPress.com site
Select a domain
Finish creating a site
Confirm that checkout doesn't open

Regression Notes

Potential unintended areas of impact

Breaking current Site Creation flow

What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
VoiceOver.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
iPhone and iPad.
Multi-tasking: Split view and Slide over. (iPad)

…ingCart methods

- Rename DomainPurchasing to SiteCreationPurchasing - Replace RegisterDomainDetailsServiceProxyProtocol with ShoppingCartServiceProtocol

- planId can now be set during SiteCreation flow - Show checkout if planId exists

staskus · 2023-10-02T11:43:31Z

cc @irfano @ravishanker

wpmobilebot · 2023-10-02T12:04:02Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21667-1012ac4
	Version	23.4
	Bundle ID	org.wordpress.alpha
	Commit	`1012ac4`
	App Center Build	WPiOS - One-Offs #7265

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2023-10-02T13:24:38Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21667-1012ac4
	Version	23.4
	Bundle ID	com.jetpack.alpha
	Commit	`1012ac4`
	App Center Build	jetpack-installable-builds #6305

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

…in-with-a-plan-to-a-cart

guarani

Tested and working great:

✅ Checkout opens if plan selected
✅ Regression test

I left some non-blocking comments.

Regarding the "Checkout opens if plan selected" test:

When a paid domain is chosen: I see the domain & the hard-coded plan (1009) in the cart as expected.
When a free domain is chosen: Before testing, I removed the hard-coded plan. The app correctly skipped checkout and went to site assembly. My understanding is that we'll still show plans (in a later PR) when a user chooses a free domain, to give them the choice between a free and paid plan. I presume the above video, "Video - free domain", was taken with a hard-coded plan because otherwise, it shouldn't open the checkout.

guarani · 2023-10-03T21:15:29Z

WordPress/Classes/ViewRelated/Site Creation/Services/ShoppingCartService.swift

+import Foundation
+
+protocol ShoppingCartServiceProtocol {
+    func createSiteCreationShoppingCart(


nit: the repeated word "creation" makes this less readable. Maybe makeSiteCreationShoppingCart would be more readable.

guarani · 2023-10-03T21:21:42Z

WordPress/Classes/ViewRelated/Site Creation/Final Assembly/SiteAssemblyWizardContent.swift

+    /// The site must be created before attempting domain and plan bundle purchasing.
+    private func attemptPlanAndDomainPurchasing(domain: DomainSuggestion, planId: Int, site: Blog) {


nit: Is this checkout web view shown to users who choose a free domain (e.g. xyz.wordpress.com`) and a paid plan? If so, it might be more descriptive to not mention "plan and domain" here since it could be a plan and domain bundle OR just a plan.

Correct. Yes, it will be shown to users who choose a free domain and paid plan. I will try to make it clearer.

…in-with-a-plan-to-a-cart

staskus · 2023-10-04T09:39:43Z

When a free domain is chosen: Before testing, I removed the hard-coded plan. The app correctly skipped checkout and went to site assembly. My understanding is that we'll still show plans (in a later PR) when a user chooses a free domain, to give them the choice between a free and paid plan. I presume the above video, "Video - free domain", was taken with a hard-coded plan because otherwise, it shouldn't open the checkout.

@guarani correct. Both cases had a plan hardcoded, therefore both cases had Checkout opened. 👍

staskus added 5 commits October 2, 2023 13:31

Replace deprecated createTemporaryDomainShoppingCart with createShopp…

3571df2

…ingCart methods

Create ShoppingCartService for purchasing domain with a plan

edd4a76

Replace DomainPurchasing to SiteCreationPurchasing flow

d24a748

- Rename DomainPurchasing to SiteCreationPurchasing - Replace RegisterDomainDetailsServiceProxyProtocol with ShoppingCartServiceProtocol

Introduce planId to SiteCreator

3f353b1

- planId can now be set during SiteCreation flow - Show checkout if planId exists

Temporary set WordPressKit to branch

2f16a16

staskus added [Type] Task Plans in Site Creation labels Oct 2, 2023

staskus added this to the 23.5 milestone Oct 2, 2023

staskus requested a review from guarani October 2, 2023 11:41

staskus mentioned this pull request Oct 2, 2023

Created functionality to add domain with a plan to a cart wordpress-mobile/WordPressKit-iOS#628

Merged

3 tasks

Remove redundant comment

718014b

Merge branch 'trunk' into task/21636-create-functionality-to-add-doma…

e8ddb12

…in-with-a-plan-to-a-cart

guarani approved these changes Oct 3, 2023

View reviewed changes

staskus added 2 commits October 4, 2023 12:35

Merge branch 'trunk' into task/21636-create-functionality-to-add-doma…

9e31f7f

…in-with-a-plan-to-a-cart

Bump WordPressKit-iOS to 8.6.0-beta.1

5856e2b

staskus added 2 commits October 4, 2023 12:42

Rename createSiteCreationShoppingCart to makeSiteCreationShoppingCart

15a01ae

Rename attemptPlanAndDomainPurchasing to attemptPurchasing

1012ac4

staskus enabled auto-merge October 4, 2023 09:55

staskus merged commit 401211b into trunk Oct 4, 2023

staskus deleted the task/21636-create-functionality-to-add-domain-with-a-plan-to-a-cart branch October 4, 2023 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plans in Site Creation: Create functionality to add domain with a plan to a cart #21667

Plans in Site Creation: Create functionality to add domain with a plan to a cart #21667

staskus commented Oct 2, 2023 •

edited

Loading

staskus commented Oct 2, 2023

wpmobilebot commented Oct 2, 2023 •

edited

Loading

wpmobilebot commented Oct 2, 2023 •

edited

Loading

guarani left a comment

guarani Oct 3, 2023

guarani Oct 3, 2023

staskus Oct 4, 2023

staskus commented Oct 4, 2023

		/// The site must be created before attempting domain and plan bundle purchasing.
		private func attemptPlanAndDomainPurchasing(domain: DomainSuggestion, planId: Int, site: Blog) {

Plans in Site Creation: Create functionality to add domain with a plan to a cart #21667

Plans in Site Creation: Create functionality to add domain with a plan to a cart #21667

Conversation

staskus commented Oct 2, 2023 • edited Loading

Description

To test:

Checkout opens if plan selected

Video - paid domain

Video - free domain

Regression

Regression Notes

staskus commented Oct 2, 2023

wpmobilebot commented Oct 2, 2023 • edited Loading

wpmobilebot commented Oct 2, 2023 • edited Loading

guarani left a comment

Choose a reason for hiding this comment

guarani Oct 3, 2023

Choose a reason for hiding this comment

guarani Oct 3, 2023

Choose a reason for hiding this comment

staskus Oct 4, 2023

Choose a reason for hiding this comment

staskus commented Oct 4, 2023

staskus commented Oct 2, 2023 •

edited

Loading

wpmobilebot commented Oct 2, 2023 •

edited

Loading

wpmobilebot commented Oct 2, 2023 •

edited

Loading